fix: grab frame button ignores crop, scale, and rotate edits#909
fix: grab frame button ignores crop, scale, and rotate edits#909Nightcoder-26 wants to merge 3 commits into
Conversation
The 'Grab Frame' feature previously drew the raw video element directly onto a canvas, completely ignoring any zoom, crop, rotation, or aspect ratio changes the user applied in the UI. Fix: Replaced the manual canvas drawing logic with the existing 'captureFrameAsPng' utility from frame-export.ts, which correctly computes and applies all recipe transformations before rendering the image.
|
Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
👋 Thanks for your PR, @Nightcoder-26!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
✅ PR Format Check Passed — @Nightcoder-26Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
|
@magic-peach kindly review the PR and merge it |
# Conflicts: # src/components/VideoPreview.tsx
|
@magic-peach please review it and merge or close it, if you want me to any changes kindly mention that i am happy to work accordingly |
|
@Nightcoder-26 The code change looks good — replacing the manual canvas frame capture with However, build/lint/typecheck CI hasn't run on this PR. Could you push a minor update (e.g., add a blank line and remove it) to trigger the full CI suite? We need build, lint, and typecheck to pass before merging. Once CI passes, this will be merged quickly! |
|
Hi! @magic-peach I can see the CI is blocked on "5 workflows awaiting approval" — this is GitHub's automatic fork protection policy and the build workflows literally cannot start until a maintainer approves them from the Checks tab. The local build passes cleanly — ✓ Compiled successfully, ✓ Linting and checking validity of types. Could you please click "Approve and run workflows" in the PR's Checks section? That's the only remaining step before this can be merged. 🙏 |
|
@magic-peach kindly check the PR and merge it and close it as soon as possible. the issues has been solved please review it humble request Thank you! |
Description
Fixes a bug where the "Grab Frame" button completely ignored all user edits (such as cropping, zooming, rotating, or aspect ratio changes) and instead downloaded the raw, original video frame directly from the
Fix: Replaced the manual canvas drawing logic inside VideoPreview.tsx with the existing captureFrameAsPng(video, recipe) utility from frame-export.ts. This utility correctly computes and applies all recipe transformations (scale, rotation, crop dimensions) to the canvas before saving the PNG.
Related Issue
fixes #905
Type of Contribution
Participant Info
Screen Recording
Recording.2026-05-22.130756.mov
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in